[Rd] rw1020 Rcmd INSTALL path\ deletes rw1020\library\* (PR#789)

Prof Brian D Ripley ripley@stats.ox.ac.uk
Fri, 22 Dec 2000 07:01:44 +0000 (GMT)


Using a trailing dir separator is wrong, and Windows is much less
tolerant of it than most Unixes.  I have not checked most of these
utilities using \, only /, as the shells I use demand \ be doubled
and do path completion only with /.

The diagnosis is correct: basename in Perl is failing when given that path.
I will add some sanity checks.

On Fri, 22 Dec 2000 cberry@tajo.ucsd.edu wrote:

> 
> The trailing backslash seems to be the culprit.
> 
> 
> After looking at rw1020\bin\INSTALL, I noticed
> 
> 	$pkg =~ s/\/$//;
> 
> which I assume is to strip the trailing slash from a package name
> before obtaining the package name and cleaning out its directory
> 
> I added 
> 
> 	$pkg =~ s/\\$//;
> 
> immediately after this line. Rerunning 
> 
> 	Rcmd INSTALL C:\rw1011\src\library\bqtl\
> 
> with that change seemed to work OK
> 
> The session follows further below. 
> 
> ----------------------------------------
> More details:
> 
> Using cmdproxy.exe under emacs shell-mode under Win98,
> 
> It seems that the problem arose when I used 
> 
> 	Rcmd INSTALL C:\rw1011\src\library\bqtl\
> 
> A subsequent
> 
> 	Rcmd INSTALL C:\rw1011\src\library\bqtl
> 
> also failed. 
> 
> Inspection showed that all the directories under C:\rw1011\src\library
> were gone.
> 
> I reran rwinst.exe to put them back in place
> 
> then I reran
> 
> 	Rcmd INSTALL C:\rw1011\src\library\bqtl
> 
> and everything seemed to go thru OK (up to creating chtml, which the
> system was not configured to do anyway. But library(bqtl) works, examples
> all run, all seems OK, etc.)
> 
> 
> --please do not edit the information below--
> 
> Version:
>  platform = i386-pc-mingw32
>  arch = x86
>  os = Win32
>  system = x86, Win32
>  status = 
>  major = 1
>  minor = 2.0
>  year = 2000
>  month = 12
>  day = 15
>  language = R
> 
> Windows 9x 4.10 (build 2222)  A 
> 
> Search Path:
>  .GlobalEnv, package:ctest, Autoloads, package:base
> 
> ----------------------------------------
> 
> The session:
> 
> 
> 
> C:\rw1020\src\gnuwin32>Rcmd INSTALL C:\rw1011\src\library\bqtl\
> 
> make: Entering directory `/RW1020/src/gnuwin32'
> make DLLNM=  EXTRADOCS= \
>   -C C:/rw1011/src/library/.o PKG=.o RHOME=C:/RW1020 RLIB=C:/RW1020/library \
>   -f C:/RW1020/src/gnuwin32/MakePkg
> make: Entering an unknown directory
> make: *** C:/rw1011/src/library/.o: No such file or directory.  Stop.
> make: Leaving an unknown directory
> make: *** [pkg-.o] Error 2
> make: Leaving directory `/RW1020/src/gnuwin32'
> *** Installation of  failed ***
> 
> installing R.css in C:/RW1020/library
> cp: cannot create regular file `C:/RW1020/library/R.css': No such file or directory
> 
> C:\rw1020\src\gnuwin32>Rcmd INSTALL --help
> [deleted]
> C:\rw1020\src\gnuwin32>Rcmd INSTALL C:\rw1011\src\library\bqtl
> 
> make: Entering directory `/RW1020/src/gnuwin32'
> make DLLNM=  EXTRADOCS= \
>   -C C:/rw1011/src/library/bqtl PKG=bqtl RHOME=C:/RW1020 RLIB=C:/RW1020/library \
>   -f C:/RW1020/src/gnuwin32/MakePkg
> make[1]: Entering directory `/rw1011/src/library/bqtl'
> ---------- Making package bqtl ------------
> mkdir -p C:/RW1020/library/bqtl
> cp -r   ./DESCRIPTION  ./INDEX  ./TITLE ./README C:/RW1020/library/bqtl/
>    adding build stamp to DESCRIPTION
> make[1]: *** [C:/RW1020/library/bqtl/zzzz] Error 2
> make[1]: Leaving directory `/rw1011/src/library/bqtl'
> make: *** [pkg-bqtl] Error 2
> make: Leaving directory `/RW1020/src/gnuwin32'
> *** Installation of bqtl failed ***
> 
> installing R.css in C:/RW1020/library
> 
> [[[AT THIS POINT I NOTICED C:\rw1020\library\base, etc were gone. 
>  They were replaced. Then ...]]]
> 
> C:\rw1020\src\gnuwin32>Rcmd INSTALL C:\rw1011\src\library\bqtl
> 
> [[[ rest deleted - the package seemed to work OK ]]]
> 
> 
> 
> Charles C. Berry                        (858) 534-2098 
>                                          Dept of Family/Preventive Medicine
> E mailto:cberry@tajo.ucsd.edu	         UC San Diego
> http://hacuna.ucsd.edu/members/ccb.html  La Jolla, San Diego 92093-0645
> 
>  
> 
> 
> -.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-
> r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html
> Send "info", "help", or "[un]subscribe"
> (in the "body", not the subject !)  To: r-devel-request@stat.math.ethz.ch
> _._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._
> 

-- 
Brian D. Ripley,                  ripley@stats.ox.ac.uk
Professor of Applied Statistics,  http://www.stats.ox.ac.uk/~ripley/
University of Oxford,             Tel:  +44 1865 272861 (self)
1 South Parks Road,                     +44 1865 272860 (secr)
Oxford OX1 3TG, UK                Fax:  +44 1865 272595

-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-
r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html
Send "info", "help", or "[un]subscribe"
(in the "body", not the subject !)  To: r-devel-request@stat.math.ethz.ch
_._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._