[Rd] readline 4.2 shows R has (fatal) incorrect declarations. (PR#913)

ripley@stats.ox.ac.uk ripley@stats.ox.ac.uk
Thu, 12 Apr 2001 17:08:58 +0200 (MET DST)


Specifically Solaris 2.7 and R 1.2.2 patched, but the principle is general.

src/unix/sys-unix.c declares the function tilde_expand from readline,
incorrectly for readline 4.x.  That's OK in 4.1 as it is not in the
included headers, but it is for 4.2, and so compilation fails (under gcc
2.95.3 at least).

The quick fix is (ca line 88)

char *tilde_expand(const char*);
                   ^^^^^

but we should really check the readline version number and only
define this in earlier versions.

There is also a conflict in src/unix/sys-std.c: readline_handler
is defined with unsigned char * but it should be char * according to the
readline 4.2 prototype.


-- 
Brian D. Ripley,                  ripley@stats.ox.ac.uk
Professor of Applied Statistics,  http://www.stats.ox.ac.uk/~ripley/
University of Oxford,             Tel:  +44 1865 272861 (self)
1 South Parks Road,                     +44 1865 272860 (secr)
Oxford OX1 3TG, UK                Fax:  +44 1865 272595


-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-
r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html
Send "info", "help", or "[un]subscribe"
(in the "body", not the subject !)  To: r-devel-request@stat.math.ethz.ch
_._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._