[Rd] model.matrix.default chokes on backquote (PR#7202)
ggrothendieck at myway.com
Mon Aug 30 03:35:21 CEST 2004
Peter Dalgaard <p.dalgaard at biostat.ku.dk> writes:
> "Gabor Grothendieck" <ggrothendieck at myway.com> writes:
> > > > as.character(attr(terms(`a(b)`~`c(d)`),"variables"))
> > >  "list" "`a(b)`" "`c(d)`"
> > >
> > > whereas for instance
> > >
> > > > sapply(attr(terms(`a(b)`~`c(d)`),"variables")[-1],as.character)
> > >  "a(b)" "c(d)"
> > 1. That is quite subtle but a fix based on that would appear to
> > solve it.
> Hmm, not quite. I tried, and terms like offset(foo) gets me in
> trouble. Probably, I was fixing the wrong end of the original problem:
> In the comparisons, we can't have one side with backquotes and the
> other without them. That doesn't have to mean that they should be
> removed from both sides, and indeed it would get us in trouble if
> someone was perverse enough to do things like
> y ~ `offset(foo)` + offset(foo)
> I.e. perhaps the real issue is that names(data) gets generated without
> Anyways, this is a real can of worms and I'm not sure we're not too
> close to 2.0.0 to start tampering with it...
How about a partial fix that does not address pathological
cases where the variable names themselves have embedded
backquotes but does address the common cases such as:
y <- ts(1:10); x1 <- y^2; x2 <- y^4
lm(`lag(y)` ~ ., cbind(lag(y), x1, diff(x2)) )
without having to resort to:
lm(lag.y ~ ., cbind(lag.y = lag(y), x1, diff(x2)) )
More information about the R-devel