[Rd] methods package: A _R_CHECK_LENGTH_1_LOGIC2_=true error

Martin Maechler m@ech|er @end|ng |rom @t@t@m@th@ethz@ch
Sat Jul 6 15:21:32 CEST 2019


>>>>> Suharto Anggono Suharto Anggono via R-devel 
>>>>>     on Thu, 4 Jul 2019 15:13:55 +0000 writes:

    > In 'conformMethod', there is another instance of
    > omittedSig & <something about signature[omittedSig]> .
    > It just affects error message.

    > Original:
    >     if(any(is.na(match(signature[omittedSig], c("ANY", "missing"))))) {
    >         bad <- omittedSig & is.na(match(signature[omittedSig], c("ANY", "missing")))

    > After r76756:
    >     if(any(iiN <- is.na(match(signature[omittedSig], c("ANY", "missing"))))) {
    >         bad <- omittedSig & iiN

Yes, thank you, that's same "internal logic" error as later.

One difference is that I think the above case cannot be
triggered by setMethod() .. one needs an explicit "artificial"
conformMethod() call.
Still, of course, it's wrong and should be corrected.
I've started to test changes .. maye not get to commit (with
enough confidence) before taking the train to
useR! 2019 @  Toulouse (France).

Martin



More information about the R-devel mailing list