[Rd] expand.model.frame() fails when subset is specified (PR# 979)

Peter Dalgaard BSA p.dalgaard@biostat.ku.dk
15 Jun 2001 01:03:42 +0200


"Warnes, Gregory R" <gregory_r_warnes@groton.pfizer.com> writes:

>   > Thanks. This is also present in the current pre-1.3.0. Your patch
>   > looks correct, but I wonder if the default for "enclos" 
>   > should not be
>   > environment(formula(model)) rather than parent.frame() as it is now?
>   > 
>   > (And wouldn't it be better named "envir"?)
> 
> Peter,
> 
> I was merely making an incremental improvement, your suggestions provide
> additional improvements.   Go right ahead and make the changes.  [This seems
> wierd, are you asking 
> me, non-R-core person that I am, permission to make changes to the R source
> code?]

Sorry, I might have made that more clear. Followups on bug reports get
CC'ed into R-bugs and stored with the original report, as well as
circulated via R-devel. I was just making a note for whoever might have
a better informed opinion than myself, as well as for the person who'll
get around to putting in the fix eventually (which might well be
myself). 

-- 
   O__  ---- Peter Dalgaard             Blegdamsvej 3  
  c/ /'_ --- Dept. of Biostatistics     2200 Cph. N   
 (*) \(*) -- University of Copenhagen   Denmark      Ph: (+45) 35327918
~~~~~~~~~~ - (p.dalgaard@biostat.ku.dk)             FAX: (+45) 35327907
-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-
r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html
Send "info", "help", or "[un]subscribe"
(in the "body", not the subject !)  To: r-devel-request@stat.math.ethz.ch
_._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._